Repository navigation
new Hessian API, alternative version of evaluate, heap-backed. Drop the NaN sentinel. - #359
Open
Thiago316316 wants to merge 3 commits into
Open
Thiago316316 wants to merge 3 commits into
Thiago316316 wants to merge 3 commits into
Conversation
…he NaN sentinel on Hessian.
Contributor
Author
|
@kmolan The two bare-metal failures come from CI's @ stable moving to Rust 1.99: on 1.97 the smoke binary is the same size before and after this PR, and riscv-rt builds. And as always 1.85 pending. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Removal of the NaN as sentinel on Hessian to prevent real NaN result to be re-evaluated unnecessarily. Adding the heap-backed/alloc gated evaluate version.
issue #219
Checklist
cargo test+cargo clippy --all-targetsclean locallyunwrap/expect/panicon library paths (typed errors instead)