Repository navigation
fix(kitfile): reject layer paths outside the context directory - #1289
Open
ManthanNimodiya wants to merge 1 commit into
Open
ManthanNimodiya wants to merge 1 commit into
ManthanNimodiya wants to merge 1 commit into
Conversation
Validate now rejects non-local paths and checks prompt paths, so pack fails instead of writing an empty layer. Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
ManthanNimodiya
force-pushed
the
fix/pack-reject-paths-outside-context
branch
from
October 31, 2026 17:57
00ea01f to
6e994d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kitfile validation only rejected absolute paths and skipped prompt paths entirely, so
../or absolute layer paths packed an empty layer.Validation now rejects any local layer path that escapes the context directory and applies path checks to prompts too.
pkg/artifact/kitfile.go: add prompts to path checks; reject non-local paths (same rule asfilesystem.VerifySubpath)pkg/artifact/testdata/validation/: cases for../prompt,../dataset, absolute prompt, and a valid in-context pathNote: prompts now also get the existing duplicate-path check, same as all other layer types.
Linked issues
Fixes #1286
AI-Assisted Code