Fix zip deflate - #234
Open
zapu wants to merge 1 commit into
Open
Conversation
NOTE: OpenPGP ZIP compression is a raw DEFLATE stream, without zlib headers. Fixed an undefined reference to `fake_zip_deflate`, presumably the function had a typo in the name. Added a way to specify the compression algo in `burn` API so it's available to the end users and we can also test it end to end. Added roundtrip tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the effort to clean up obvious runtime errors due to undefined references. ZIP deflate had a typo in the function name, but that code path was not exercised, and it didn't work anyway. Fix was trivial so I've just done it, exposed compression algo setting in Burner, and added roundtrip tests for different compression settings as well as invalid setting.