Avoid clipboard prompts in embedded live views - #363
Open
masnwilliams wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
why
A clipboard permission prompt can take keyboard focus from a cross-origin live-view iframe while mouse input continues through its independent handler. The overlay remains the active element inside the iframe, but trusted key events no longer reach it.
The native paste path already reads
ClipboardEvent.clipboardData, so embedded users can still paste without triggering a permission request.validation
Tested against exact image
kernel-cu-v63:863808busing Chromium 151, fresh viewer profiles, trusted OS-level input, client-stage counters, privacy-safe Neko receipt/injection markers, and a remote input assertion.prompt, iframe focus dropped, client sent the mouse down, Neko received/authorized/injected both pointer events, and 0/5 keys reached the client or serverbun run lint --no-fix(0 errors; existing warnings)bun run build(passes; existing lint and bundle-size warnings)