Conversation
The tools/testing/selftests/bpf directory in the kernel source tree contains the test_bpftool_build.sh script that ensures that the various supported ways of building bpftool work correctly. This test isn't currently part of the tests automatically executed in CI. Add a new layer of workflows in test.yml to run tests that will exercise build commands. As a first sub-workflow, add a bpftool build workflow: test.yml -> test-build-commands.yml -> build->bpftool.yml This test-build-commands workflow can be extended later to support other artifacts build test, for example to test the different ways of building selftests. The new build-bpftool workflow aims to validate the different ways of building the bpftool CLI, as exercised by the test_bpftool_build.sh in the kernel source tree (in tools/testing/selftests/bpf). As the test has only a few dependencies (only a build test, no dependency on built artifact), the added workflow remains simple and isolated from the other "build-and-tests" workflows: - it only tests host build, so no need to run it as many time as the matrix script generates configurations - supports download_sources flag, so can be run from kernel tree or vmtest tree Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com> --- This new workflow does not make the whole test_bpftool_build.sh execute in CI; as some subtests are gated by the presence of a .config. I suspect this to be hiding a broader kbuild issue as bpftool does not really depend on .config, I'll fix this separately in another series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tools/testing/selftests/bpf directory in the kernel source tree contains the test_bpftool_build.sh script that ensures that the various supported ways of building bpftool work correctly. This test isn't currently part of the tests automatically executed in CI.
Add a new layer of workflows in test.yml to run tests that will exercise build commands. As a first sub-workflow, add a bpftool build workflow:
test.yml -> test-build-commands.yml -> build->bpftool.yml
This test-build-commands workflow can be extended later to support other artifacts build test, for example to test the different ways of building selftests.
The new build-bpftool workflow aims to validate the different ways of building the bpftool CLI, as exercised by the test_bpftool_build.sh in the kernel source tree (in tools/testing/selftests/bpf). As the test has only a few dependencies (only a build test, no dependency on built artifact), the added workflow remains simple and isolated from the other "build-and-tests" workflows:
This new workflow does not make the whole test_bpftool_build.sh execute in CI; as some subtests are gated by the presence of a .config. I suspect this to be hiding a broader kbuild issue as bpftool does not really depend on .config, I'll fix this separately in another series.