Conversation
Benchmark Regression ReportThreshold: 10.00%
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae8b09917c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else => return err, | ||
| }; | ||
| if (explicit) |value| { | ||
| return .{ .value = value, .source = .env }; |
There was a problem hiding this comment.
Strip
v prefix from CODEDB_VERSION before release URL use
When CODEDB_VERSION is set to a tag-like value such as v0.2.57, resolveTargetVersion returns it unchanged, but later download URLs are built as .../download/v{s}/..., producing vv0.2.57 and causing update failure for explicit-version updates. This is a real mismatch because compareVersions already accepts prefixed versions, so users can pass validation and still fail during download.
Useful? React with 👍 / 👎.
| const command_exe = commandExecutablePath(command_line) orelse return false; | ||
| return std.mem.eql(u8, normalizeExecutablePath(command_exe), normalizeExecutablePath(executable_path)); |
There was a problem hiding this comment.
Resolve non-absolute argv0 when matching nuke target process
commandTargetsBinary only treats a process as in-scope when the command token equals the absolute self path (or contains that exact string). For processes launched from PATH (argv0 like codedb serve), this check returns false even when they are the same install, so codedb nuke can leave same-install serve/mcp processes running while uninstalling files.
Useful? React with 👍 / 👎.
Summary
checksums.sha256, and no-ops when already currentcodedb updatein CLI helpcodedb nukeprocess termination to the same executable path so uninstalling one install does not kill unrelated codedb sessionsVerification
zig buildzig build test -- --test-filter "issue-150:"zig build test -- --test-filter "update:"zig build test -- --test-filter "nuke:"CODEDB_VERSION=0.2.56 ./zig-out/bin/codedb updatecodedb nukecovering snapshot/config/binary removal and a same-install dummyserveprocess