Skip to content

fix: restore help CLI build and exit behavior#238

Merged
justrach merged 1 commit intomainfrom
fix/help-compile-regression
Apr 11, 2026
Merged

fix: restore help CLI build and exit behavior#238
justrach merged 1 commit intomainfrom
fix/help-compile-regression

Conversation

@justrach
Copy link
Copy Markdown
Owner

Summary

  • restore the telemetry API surface that main.zig and mcp.zig already reference so the CLI executable builds again
  • route -h and help through the same early help path as --help, which makes all help entrypoints exit successfully
  • strengthen the issue-150 tests to assert a zero exit status and run the built binary directly instead of nesting zig build run inside the test harness

Verification

  • zig test src/tests.zig --test-filter 'issue-150:'
  • zig build run -- --help
  • zig build run -- -h
  • zig build test

@github-actions
Copy link
Copy Markdown

Benchmark Regression Report

Threshold: 10.00%

Tool Base (ns) Head (ns) Delta Status
codedb_bundle 690827 701558 +1.55% OK
codedb_changes 109996 110345 +0.32% OK
codedb_deps 30390 31336 +3.11% OK
codedb_edit 18304 18276 -0.15% OK
codedb_find 141485 139745 -1.23% OK
codedb_hot 145980 146581 +0.41% OK
codedb_outline 450613 451337 +0.16% OK
codedb_read 177753 169159 -4.83% OK
codedb_search 304144 292946 -3.68% OK
codedb_snapshot 4290906 4269822 -0.49% OK
codedb_status 256131 258955 +1.10% OK
codedb_symbol 61908 64003 +3.38% OK
codedb_tree 93075 96864 +4.07% OK
codedb_word 91715 94394 +2.92% OK

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0a6bd8d1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +185 to +186
_ = wal_path;
self.syncToCloud();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Respect WAL path in syncWalToCloud

syncWalToCloud currently discards its wal_path argument and just calls syncToCloud, which uploads/truncates telemetry.ndjson instead of the query WAL passed from mainImpl (src/main.zig calls this with queries.log before shutdown). In MCP sessions that write query/access events, this means WAL profiling data is never synced and the append-only queries.log is never cleared by this path, so behavior no longer matches the intent of the call site.

Useful? React with 👍 / 👎.

@justrach justrach merged commit 9eeb54e into main Apr 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant