fix: restore help CLI build and exit behavior#238
Conversation
Benchmark Regression ReportThreshold: 10.00%
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0a6bd8d1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _ = wal_path; | ||
| self.syncToCloud(); |
There was a problem hiding this comment.
Respect WAL path in syncWalToCloud
syncWalToCloud currently discards its wal_path argument and just calls syncToCloud, which uploads/truncates telemetry.ndjson instead of the query WAL passed from mainImpl (src/main.zig calls this with queries.log before shutdown). In MCP sessions that write query/access events, this means WAL profiling data is never synced and the append-only queries.log is never cleared by this path, so behavior no longer matches the intent of the call site.
Useful? React with 👍 / 👎.
Summary
main.zigandmcp.zigalready reference so the CLI executable builds again-handhelpthrough the same early help path as--help, which makes all help entrypoints exit successfullyissue-150tests to assert a zero exit status and run the built binary directly instead of nestingzig build runinside the test harnessVerification
zig test src/tests.zig --test-filter 'issue-150:'zig build run -- --helpzig build run -- -hzig build test