Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6a5abf486
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| markdown, | ||
| json, | ||
| yaml, | ||
| svelte, |
There was a problem hiding this comment.
Keep Language enum values stable across snapshot versions
Adding svelte before unknown changes the numeric value of Language.unknown, but snapshot serialization stores @intFromEnum(outline.language) and deserializes it with intToEnum (src/snapshot.zig), and the loader does not gate on a bumped format version. That means snapshots produced by the previous build will decode old unknown entries as svelte after this change, causing incorrect language metadata on warm restore. Please preserve ordinal stability (explicit enum values or append-only ordering) or bump/migrate snapshot format when enum layout changes.
Useful? React with 👍 / 👎.
Summary
.sveltelanguage detection and a Svelte parser wrapper that only extracts symbols from<script>blocksphpandrubybits stay aligned while addingsvelte<script>handling, detectLanguage coverage, and telemetry outputVerification
zig test src/tests.zig --test-filter 'Svelte:'zig test src/tests.zig --test-filter 'issue-59: telemetry writes session, tool, and codebase stats ndjson'zig test src/tests.zig --test-filter 'detectLanguage:'zig test src/tests.zig --test-filter 'isCommentOrBlank: detects language-specific comments'Notes
zig build teststill fails onorigin/mainbecause the pre-existingissue-150help-output tests are red in a clean baseline worktree as well.