Skip to content

fix(core/exec): run project hooks outside the command sandbox #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voarsh2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core/exec): run project hooks outside the command sandbox #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions code-rs/core/src/codex/exec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
use super::*;
use super::session::{HookGuard, RunningExecMeta};

fn project_hook_execution_policy() -> (SandboxType, SandboxPolicy) {
// codex-rs runs configured hooks through a dedicated command runtime rather
// than the model-tool sandbox. code-rs does not have that split runtime
// yet, so keep the equivalent policy at this single hook boundary.
//
// Project hooks are explicitly configured local integrations, not
// model-generated commands. Give them the existing full-access execution
// policy so they can use networking and external state, including when
// invoked during a subagent turn. This applies only to hooks; ordinary
// model commands and project commands still use the session policy.
(SandboxType::None, SandboxPolicy::DangerFullAccess)
}

fn synthetic_exec_end_payload(cancelled: bool) -> (i32, String) {
if cancelled {
(130, "Command cancelled by user.".to_string())
Expand Down Expand Up @@ -973,11 +986,11 @@ impl Session {
apply_patch: None,
};

let sandbox_type = self.resolve_internal_sandbox(false);
let (sandbox_type, sandbox_policy) = project_hook_execution_policy();
let exec_args = ExecInvokeArgs {
params: exec_params,
sandbox_type,
sandbox_policy: &self.sandbox_policy,
sandbox_policy: &sandbox_policy,
sandbox_cwd: self.get_cwd(),
code_linux_sandbox_exe: &self.code_linux_sandbox_exe,
stdout_stream: None,
Expand Down Expand Up @@ -1105,8 +1118,11 @@ impl Session {
#[cfg(test)]
mod tests {
use super::materialize_shell_script;
use super::project_hook_execution_policy;
use crate::exec::DeferredShellScript;
use crate::exec::ExecParams;
use crate::exec::SandboxType;
use crate::protocol::SandboxPolicy;
use crate::shell::BashShell;
use crate::shell::Shell;
use std::collections::HashMap;
Expand Down Expand Up @@ -1172,4 +1188,12 @@ mod tests {
]
);
}

#[test]
fn project_hooks_use_full_access_execution_policy() {
let (sandbox_type, sandbox_policy) = project_hook_execution_policy();

assert_eq!(sandbox_type, SandboxType::None);
assert_eq!(sandbox_policy, SandboxPolicy::DangerFullAccess);
}
}
Loading