Repository navigation
Preserve shell-command execution for Windows models - #622
Merged
Merged
Conversation
Keeps model-advertised shell behavior consistent across platforms when the dedicated patch tool is available. Removes obsolete platform and tool-selection coupling from the shell selection path and updates its regression test.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell_commandas the selected tool when the model advertises shell-command support.apply_patchtool independently.shellcontract whenapply_patchis enabled.Motivation
The Windows-specific tool selection previously forced shell-command-capable models back to the legacy argv-style shell tool whenever
apply_patchwas enabled.That caused PowerShell pipelines such as: