Repository navigation
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Updated the 'enabled' field for 'mod_healthcheck' from 0 to 1 in the SQL insert statement.
… supported database platforms.
Co-authored-by: Brian Teeman <brian@teeman.net>
* Show code of health check items in a modal Items returned by an async health check icon may now carry a `code` property. Such items open their code in a lightweight modal instead of navigating to a link, e.g. to show a class redefinition found by a check. - Title and code are set via textContent, never as HTML - Close button label comes from JCLOSE via Joomla.Text - Focus moves into the dialog, is kept inside while open and returns to the triggering item on close (Esc, close button or backdrop) * Use Atum's unprefixed colour variables for the code modal Joomla compiles Bootstrap without the "bs-" prefix, so --bs-body-bg and friends are undefined and the modal always fell back to its light colours. Use --body-bg, --body-color and --border-color so it follows dark mode. * Build the code modal with DOM methods instead of innerHTML Avoids innerHTML for the modal markup so no future change can turn it into an HTML injection point. * Replace remaining innerHTML in the async health check script The icon amount (value, fallback 0 and error marker) is now rendered through a small setAmount() helper using textContent and replaceChildren(), so the script no longer uses innerHTML anywhere.
The gauge and the warning filter button used hard-coded light colours, so in Atum's dark mode the gauges rendered as bright white cards and the warning filter text had too little contrast. Colours used by the gauge are now custom properties with the existing light values (light mode is unchanged). Under [data-bs-theme="dark"] they map to Atum's colour scheme variables (unprefixed, as Joomla compiles Bootstrap without the "bs-" prefix), and the warning filter button uses --warning-text-emphasis.
Fixed linktitle typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of PR 47947 joomla/joomla-cms#47947