Skip to content

Pr 47947 - #95

Merged
obuisard merged 158 commits into
6.3-devfrom
pr-47947
Nov 11, 2026
Merged

obuisard merged 158 commits into
6.3-devfrom
pr-47947

Conversation

@obuisard

Copy link
Copy Markdown
Collaborator

Copy of PR 47947 joomla/joomla-cms#47947

obuisard and others added 30 commits June 12, 2026 13:39
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
obuisard and others added 29 commits August 11, 2026 23:44
Updated the 'enabled' field for 'mod_healthcheck' from 0 to 1 in the SQL insert statement.
Co-authored-by: Brian Teeman <brian@teeman.net>
* Show code of health check items in a modal

Items returned by an async health check icon may now carry a `code`
property. Such items open their code in a lightweight modal instead of
navigating to a link, e.g. to show a class redefinition found by a check.

- Title and code are set via textContent, never as HTML
- Close button label comes from JCLOSE via Joomla.Text
- Focus moves into the dialog, is kept inside while open and returns to
  the triggering item on close (Esc, close button or backdrop)

* Use Atum's unprefixed colour variables for the code modal

Joomla compiles Bootstrap without the "bs-" prefix, so --bs-body-bg and
friends are undefined and the modal always fell back to its light
colours. Use --body-bg, --body-color and --border-color so it follows
dark mode.

* Build the code modal with DOM methods instead of innerHTML

Avoids innerHTML for the modal markup so no future change can turn it
into an HTML injection point.

* Replace remaining innerHTML in the async health check script

The icon amount (value, fallback 0 and error marker) is now rendered
through a small setAmount() helper using textContent and
replaceChildren(), so the script no longer uses innerHTML anywhere.
The gauge and the warning filter button used hard-coded light colours,
so in Atum's dark mode the gauges rendered as bright white cards and the
warning filter text had too little contrast.

Colours used by the gauge are now custom properties with the existing
light values (light mode is unchanged). Under [data-bs-theme="dark"] they
map to Atum's colour scheme variables (unprefixed, as Joomla compiles
Bootstrap without the "bs-" prefix), and the warning filter button uses
--warning-text-emphasis.
Fixed linktitle typo
@obuisard
obuisard merged commit aa652a7 into 6.3-dev Nov 11, 2026
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants