[PM Fixer] Fix gradle v9.8.0-RC2 compatibility: remove bundled 'idea' plugin removed in Gradle 9.x - #3715
Open
agrasth wants to merge 1 commit into
Open
[PM Fixer] Fix gradle v9.8.0-RC2 compatibility: remove bundled 'idea' plugin removed in Gradle 9.x#3715agrasth wants to merge 1 commit into
agrasth wants to merge 1 commit into
Conversation
…dle 9.x The IDEA IDE plugin was removed from Gradle's bundled distribution in Gradle 9.0. Both gradleproject and projectwithplugin test fixtures used `apply plugin: 'idea'`, which is evaluated at configuration time and causes an immediate build failure with Gradle 9.x: Plugin with id 'idea' not found. This made every gradle integration test fail when run with any Gradle 9.x version. The 'idea' plugin was only used for IntelliJ IDEA project-file generation — it has no effect on the build, compile, publish, or test operations exercised by the integration tests. Removing it is safe for all Gradle versions. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA pm-compat-fixer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All Gradle integration tests failed when run with Gradle v9.8.0-RC2 (and any Gradle 9.x release). The root cause is that
apply plugin: 'idea'appears in two test fixture build scripts:testdata/gradle/gradleproject/build.gradletestdata/gradle/projectwithplugin/build.gradleGradle's IDEA IDE plugin (
org.gradle.plugins.ide.idea.IdeaPlugin) was removed from Gradle's bundled distribution in Gradle 9.0. Becauseapply pluginstatements are evaluated during the configuration phase — before any task runs — this produces an immediate fatal error on every build invocation:This caused
steps.run_tests.outcome = failurefor every test that exercisesgradleprojectorprojectwithplugin, includingTestGradleBuildWithServerID,TestGradleBuildWithServerIDAndDetailedSummary,TestGradleWithDeploymentView,TestGradleBuildConditionalUpload,TestGradleBuildWithFlexPackFallback,TestGradleBuildPublishWithLocalGitVcsProps, andTestGradleBuildWithServerIDWithUsesPlugin.Fix
Remove the two
apply plugin: 'idea'lines. This is a test-fixture-only change — it does not affect product behavior in any way.The IDEA plugin generates IntelliJ IDEA project files (
.idea/,.iml) for developer ergonomics. None of the integration tests depend on IDE project-file generation; they test build, compile, artifact publish, and build-info collection. The plugin was never exercised by the test suite — it was just inherited from an old project template.Removing it is safe for all Gradle versions (5.x, 6.x, 7.x, 8.x, 9.x): the plugin was optional in older versions and non-existent in newer ones.
Compatibility impact
No exported Go symbols were changed. This change touches only Groovy build script test fixtures in
testdata/. Existing supported Gradle versions (5.6.4, 8.3) are unaffected — removingapply plugin: 'idea'has no effect on older Gradle because the plugin was purely additive.Test plan
Opened automatically by PM Compat Fixer investigating gradle v9.8.0-RC2.