Skip to content

Comments

Test TestArtifactoryClientCert sometimes fails on Windows...#3366

Merged
BlasttS merged 1 commit intomasterfrom
bugfix/Fix-windows-flakyness
Feb 24, 2026
Merged

Test TestArtifactoryClientCert sometimes fails on Windows...#3366
BlasttS merged 1 commit intomasterfrom
bugfix/Fix-windows-flakyness

Conversation

@BlasttS
Copy link
Contributor

@BlasttS BlasttS commented Feb 19, 2026

…because of a flakiness. Instead of the certificate error we got "wsarecv: An established connection was aborted" which fails the test. Adding some retries on Windows when this error happens.

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@BlasttS BlasttS added the safe to test Approve running integration tests on a pull request label Feb 19, 2026
@BlasttS BlasttS marked this pull request as ready for review February 19, 2026 16:07
@BlasttS BlasttS force-pushed the bugfix/Fix-windows-flakyness branch from b456726 to 8067467 Compare February 20, 2026 09:18
…a flakyness. Instead of the certificate error we got "wsarecv: An established connection was aborted" which fails the test. Adding some retries on Windows when this error happens.
@BlasttS BlasttS force-pushed the bugfix/Fix-windows-flakyness branch from 8067467 to 8a1b978 Compare February 20, 2026 09:20
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@ehl-jf ehl-jf added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Feb 24, 2026
@BlasttS BlasttS merged commit f3ff00f into master Feb 24, 2026
81 of 82 checks passed
@BlasttS BlasttS deleted the bugfix/Fix-windows-flakyness branch February 24, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants