Make STORE_DURATIONS_SETUP_AND_TEARDOWN_THRESHOLD a controllable env var#119
Open
kavanase wants to merge 2 commits intojerry-git:masterfrom
Open
Make STORE_DURATIONS_SETUP_AND_TEARDOWN_THRESHOLD a controllable env var#119kavanase wants to merge 2 commits intojerry-git:masterfrom
kavanase wants to merge 2 commits intojerry-git:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@jerry-git thank you for developing such a useful package!
From some testing, I found that we can mostly achieve the goals of #106 (ignoring class setup time) by modifying the
STORE_DURATIONS_TEARDOWN_THRESHOLDvalue insrc/pytest_split/plugin.py. This is a tiny change to just make that constant controllable through an environment variable.Checklist
CHANGELOG.mdOR the changes are insignificant