Increase accepted length of version string#3657
Merged
softins merged 1 commit intojamulussoftware:mainfrom Apr 21, 2026
Merged
Conversation
pljones
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Increase length of accepted version number from 30 to 50 chars. This does not change any messages sent by Jamulus, only making it accept a longer string received as the version number.
CHANGELOG: Server/Client: Allow registration and display of longer version numbers.
Context: Fixes an issue?
Replaces #3655. If a build is made from a tree with uncommitted changes, the version string includes "-dirty", which pushes the length of the version number over 30, now that a numeric timestamp has been added. This change allows a directory and a client to correctly parse such a long version number without causing a server registration to fail or a client to fail to display the version number in the connect dialog.
Does this change need documentation? What needs to be documented and how?
No, bugfix only.
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Nothing
Checklist