Skip to content

Increase accepted length of version string#3657

Merged
softins merged 1 commit intojamulussoftware:mainfrom
softins:increase-max-len-version
Apr 21, 2026
Merged

Increase accepted length of version string#3657
softins merged 1 commit intojamulussoftware:mainfrom
softins:increase-max-len-version

Conversation

@softins
Copy link
Copy Markdown
Member

@softins softins commented Apr 21, 2026

Short description of changes

Increase length of accepted version number from 30 to 50 chars. This does not change any messages sent by Jamulus, only making it accept a longer string received as the version number.

CHANGELOG: Server/Client: Allow registration and display of longer version numbers.

Context: Fixes an issue?

Replaces #3655. If a build is made from a tree with uncommitted changes, the version string includes "-dirty", which pushes the length of the version number over 30, now that a numeric timestamp has been added. This change allows a directory and a client to correctly parse such a long version number without causing a server registration to fail or a client to fail to display the version number in the connect dialog.

Does this change need documentation? What needs to be documented and how?

No, bugfix only.

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins merged commit 633c979 into jamulussoftware:main Apr 21, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Tracking Apr 21, 2026
@softins softins deleted the increase-max-len-version branch April 21, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants