Skip to content

Preserve cursor visibility for disabled FlyByCamera (#1219) - #3088

Open
adrian-andrzjewski wants to merge 1 commit into
jMonkeyEngine:masterfrom
adrian-andrzjewski:codex/issue-1219-flycam-cursor-initialization
Open

adrian-andrzjewski wants to merge 1 commit into
jMonkeyEngine:masterfrom
adrian-andrzjewski:codex/issue-1219-flycam-cursor-initialization

Conversation

@adrian-andrzjewski

Copy link
Copy Markdown

Fixes #1219

Summary

  • Preserve application-controlled cursor visibility when a disabled FlyByCamera is registered.
  • Keep existing cursor behavior when a registered camera is toggled on or off.

Validation

  • Confirmed the regression test fails before the fix because registration makes the cursor visible.
  • ./gradlew.bat :jme3-core:test --no-daemon --console=plain (passed).

@jaime-jmebot jaime-jmebot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking this on. The change is nicely focused: registering a disabled FlyByCamera no longer overrides cursor visibility that the application has already set, while the enabled registration path still installs the mappings and retains the existing visibility behavior.

I also checked the regression test against the relevant enable/disable flow. It verifies both that registration preserves a hidden cursor when the controller is disabled and that toggling the registered controller still restores the cursor when disabling it. That gives good coverage of the original regression without changing the established toggle behavior.

Looks good to me—thanks for adding the regression test alongside the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants