Repository navigation
Preserve cursor visibility for disabled FlyByCamera (#1219) - #3088
adrian-andrzjewski wants to merge 1 commit into
Conversation
jaime-jmebot
left a comment
There was a problem hiding this comment.
Hi, thanks for taking this on. The change is nicely focused: registering a disabled FlyByCamera no longer overrides cursor visibility that the application has already set, while the enabled registration path still installs the mappings and retains the existing visibility behavior.
I also checked the regression test against the relevant enable/disable flow. It verifies both that registration preserves a hidden cursor when the controller is disabled and that toggling the registered controller still restores the cursor when disabling it. That gives good coverage of the original regression without changing the established toggle behavior.
Looks good to me—thanks for adding the regression test alongside the fix!
Fixes #1219
Summary
Validation
./gradlew.bat :jme3-core:test --no-daemon --console=plain(passed).