Repository navigation
Wrap invalid XML IntMap keys as IOException - #3074
adrian-andrzjewski wants to merge 1 commit into
Conversation
|
@stephengold Could you review this fix for #2039 when you have a chance? Thanks. |
jaime-jmebot
left a comment
There was a problem hiding this comment.
Hi, thanks for putting together this focused fix. The importer now translates malformed integer map keys into an IOException while retaining the original NumberFormatException as its cause, which gives callers the checked error they expect without losing useful parse details.
I also checked the regression test: it exercises the XML import path with a deliberately corrupted key and verifies both the exception type and cause, while leaving the shared binary map coverage untouched. The change is scoped to the affected XML reader and looks consistent with the surrounding importer error handling. Looks solid to me—thanks for addressing this!
|
@adrian-andrzjewski Sorry I'm not available to review this PR. |
Summary
readIntSavableMapkeys fromNumberFormatExceptiontoIOException, preserving the parse exception as the cause.Fixes #2039
Validation
:jme3-plugins:test --no-daemon --console=plain— all 47 tests passed.NumberFormatException, then passed with this change.