Repository navigation
Fix MatParam.toString() when J3M formatting is unavailable (#2523) - #3072
adrian-andrzjewski wants to merge 1 commit into
Conversation
jaime-jmebot
left a comment
There was a problem hiding this comment.
Hi, thanks for addressing this—this is a focused fix for a frustrating debugging case, and the fallback keeps MatParam.toString() useful for values that cannot be represented in J3M syntax.
I reviewed the implementation and regression tests. Preserving getValueAsString() whenever it returns a supported format avoids changing existing output, while the array-specific formatting makes unsupported array values readable instead of exposing Java’s type-and-identity strings. The tests cover matrices, primitive and object arrays, supported vector formatting, and null values, which exercises the important behavior boundaries here.
Looks good to me. Thanks for adding the regression coverage alongside the fix!
|
@yaRnMcDonuts Could you review this focused fix for #2523? It preserves J3M formatting where supported and reports matrix and array values when it is not. I validated it with the full jme3-core test suite and Checkstyle. |
Summary
Fixes #2523
Validation