Add HSVUtils.glsllib

[yaRnMcDonuts]

Adds support for converting between RGB and HSV to allow for adjusting colors in HSV color space in shaders.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new GLSL utility file, HSVUtils.glsllib, which provides essential functions for converting colors between RGB and HSV color spaces. This enables developers to easily manipulate colors in shaders by adjusting hue, saturation, and value, offering greater flexibility for dynamic visual effects.

Highlights

• New GLSL Utility: A new GLSL shader library file, HSVUtils.glsllib, was added to the project.
• Color Space Conversion: Implemented functions rgb2hsv and hsv2rgb for converting colors between RGB and HSV color spaces.
• Dynamic Color Adjustment: Included alterColorWithHsvOffset to allow for dynamic adjustment of colors using HSV offsets within shaders.

Changelog

• jme3-core/src/main/resources/Common/ShaderLib/HSVUtils.glsllib
  • Added rgb2hsv function for converting RGB color to HSV.
  • Added hsv2rgb function for converting HSV color to RGB.
  • Added alterColorWithHsvOffset function to apply HSV offsets to a color, wrapping hue and clamping saturation/value.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new GLSL shader library HSVUtils.glsllib with utility functions for RGB to HSV color space conversion and color adjustment. The implementation of the conversion functions is a compact and efficient, branchless approach. My feedback includes a suggestion to replace a magic number with a named constant for better code clarity and maintainability.

[yaRnMcDonuts]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces HSVUtils.glsllib, a new shader library for converting between RGB and HSV color spaces. This functionality is then exposed as an HSVOffset material parameter in PBRLighting and Unshaded materials, allowing for powerful color adjustments in shaders. The implementation is efficient and well-integrated. I have one suggestion to improve maintainability by adding a comment to credit the source of the complex conversion algorithms.