correct comments in gateway subject alt names#3692
Open
ramaraochavali wants to merge 1 commit intoistio:masterfrom
Open
correct comments in gateway subject alt names#3692ramaraochavali wants to merge 1 commit intoistio:masterfrom
ramaraochavali wants to merge 1 commit intoistio:masterfrom
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
added
the
release-notes-none
istio-testing
added
the
size/XS
ramaraochavali
commented
Apr 15, 2026
| // A list of alternate names to verify the subject identity in the | ||
| // certificate presented by the client. | ||
| // Requires TLS mode to be set to `MUTUAL`. | ||
| // When multiple certificates are provided via `credential_names` or `tls_certificates`, |
Contributor
Author
There was a problem hiding this comment.
I have incorrectly added this one of the previous PRs. The server side certificates have no role in SAN list here - these are validated against client certs
zirain
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.