[48] refactor to use free functions

[trel]

currently a single commit beyond branch 36.m, will rebase once that is merged.

all tests pass

[alanking]

What is the relationship between this PR and #44? Oh, I guess that's what 36.m is referring to. Nevermind.

[trel]

yes, sorry - this builds on #44

[trel]

coverage at 91%

[trel]

rebased, single commit.

ready for review.

[trel]

$ coverage report
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
irods_http_client/__init__.py                4      0   100%
irods_http_client/collections.py            99      0   100%
irods_http_client/common.py                 25      0   100%
irods_http_client/data_objects.py          295      2    99%
irods_http_client/irods_http_client.py      21      2    90%
irods_http_client/queries.py                52      0   100%
irods_http_client/resources.py              75      0   100%
irods_http_client/rules.py                  22      0   100%
irods_http_client/tickets.py                38      0   100%
irods_http_client/users_groups.py          101      0   100%
irods_http_client/zones.py                  39      0   100%
------------------------------------------------------------
TOTAL                                      771      4    99%

the two lines in data_objects.py are reading and writing with a ticket. not sure how to do that.

[korydraughn]

Looks good overall.

The main thing is in how errors are checked (string comparisons) and checking of HTTP status codes.

[trel]

only one line untested - not sure how to generate that error text at the moment.

$ coverage report
Name                         Stmts   Miss  Cover
------------------------------------------------
irods_http/__init__.py           3      0   100%
irods_http/collections.py       90      0   100%
irods_http/common.py            21      0   100%
irods_http/data_objects.py     281      0   100%
irods_http/irods_http.py        27      1    96%
irods_http/queries.py           49      0   100%
irods_http/resources.py         68      0   100%
irods_http/rules.py             20      0   100%
irods_http/tickets.py           37      0   100%
irods_http/users_groups.py      89      0   100%
irods_http/zones.py             35      0   100%
------------------------------------------------
TOTAL                          720      1    99%

[alanking]

Given the size of this change and the fact that this hasn't been released yet, are there any areas in particular that you feel need special attention for review?

[trel]

At this point, after the refactor to free functions, module naming, and lots of coverage work and test cleanup... I think there is only the one discussion about multipart/form-data that remains - #49 (comment)

Everything else feels pretty clean, and any fixups could happen after an initial release.

[korydraughn]

There's one unresolved comment left?
Do the tests still pass?

[trel]

comment resolved.

yes, all passing.

$ coverage report
Name                         Stmts   Miss  Cover
------------------------------------------------
irods_http/__init__.py           3      0   100%
irods_http/collections.py       91      0   100%
irods_http/common.py            24      0   100%
irods_http/data_objects.py     283      0   100%
irods_http/irods_http.py        27      1    96%
irods_http/queries.py           49      0   100%
irods_http/resources.py         68      0   100%
irods_http/rules.py             20      0   100%
irods_http/tickets.py           37      0   100%
irods_http/users_groups.py      89      0   100%
irods_http/zones.py             35      0   100%
------------------------------------------------
TOTAL                          726      1    99%

[korydraughn]

Pound it.

[trel]

all pounded.