Conversation
The attribute was in the documentation 'forever' but I obviously forgot it when implementing stricter attribute checks. Fixes #3211
There was a problem hiding this comment.
Pull request overview
This PR fixes strict attribute validation to allow configuring a router ID at the node level (node.router_id), aligning the implementation with long-standing documentation (Fixes #3211).
Changes:
- Adds
router_idto the globalnodeattribute schema as an IPv4/id-based value. - Updates the
rid-pool-overflowerror fixture to reflect the new validation behavior (invalid value instead of invalid attribute).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
netsim/defaults/attributes.yml |
Adds node.router_id to the validated node attributes list (type: ipv4, use: id). |
tests/errors/rid-pool-overflow.log |
Updates expected error output now that router_id is a valid node attribute and fails type validation instead of attribute validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute was in the documentation 'forever' but I obviously forgot it when implementing stricter attribute checks.
Fixes #3211