fix(chip): scale slotted icon size by chip size#30961
Merged
OS-susmitabhowmik merged 2 commits intonextfrom Feb 20, 2026
Merged
fix(chip): scale slotted icon size by chip size#30961OS-susmitabhowmik merged 2 commits intonextfrom
OS-susmitabhowmik merged 2 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-susmitabhowmik
force-pushed
the
ROU-12572-fix-icon-size
branch
from
38fd969 to
5e9729d
Compare
brandyscarney
approved these changes
Feb 20, 2026
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good! We should add some screenshot tests for chip sizes to avoid future regressions but since none exist right now I am approving. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
When an icon was placed within a chip, the icon size was the same regardless of the chip size.
What is the new behavior?
Scales the size of the icon based on design specifications.
Does this introduce a breaking change?
Other information