fix(radio-group): prevent DOMException and NotFoundError when filtering radios#30958
Merged
OS-jacobbell merged 3 commits intomainfrom Feb 19, 2026
Merged
fix(radio-group): prevent DOMException and NotFoundError when filtering radios#30958OS-jacobbell merged 3 commits intomainfrom
OS-jacobbell merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-jacobbell
changed the title
brandyscarney
requested changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #30279 resolves #30359
What is the current behavior?
While Ionic's
stencil.config.tssetsexperimentalSlotFixes: true, the fixes never get applied at runtime. Ionic is using an external runtime, so Ionic components importdefineCustomElementfrom@stencil/core/internal/clientat runtime and this code has no awareness of the project's stencil configuration.This leads to a
NotFoundError(Failed to execute 'removeChild' on 'Node') when filtering or dynamically removing radios in anion-radio-group. The error occurs becauseion-radio-groupwraps its slotted content in an internal<div>.What is the new behavior?
By setting
externalRuntime: false, Stencil generates a project-specific file withdefineCustomElementthat components import. This file has the project's build settings baked in, correctly applying slot fixes.Additionally, the internal wrapper
<div>around the slotted content inion-radio-groupis removed. With slot fixes correctly applied and the wrapper removed, radios can be filtered or dynamically removed without triggeringNotFoundErrororDOMExceptions.Does this introduce a breaking change?
Other information
External Runtime is enabled by default and designed for projects that import Stencil components from multiple sources. This is flawed because those components will not be running with the runtime settings for which they were made.