Fix admin search for Address and Contact company foreign keys - #12440
Merged
SchrodingersGat merged 1 commit intoJul 22, 2026
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
SchrodingersGat
approved these changes
Jul 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12440 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 1442 1442
Lines 94942 94942
Branches 11101 11101
=======================================
Hits 82482 82482
Misses 12395 12395
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
pushed a commit
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a Django admin search error for the Address and Contact models.
Problem
Searching in the Address or Contact admin pages raises the following error because
search_fieldsincludes thecompanyForeignKeydirectly:Django attempts to apply the
icontainslookup to theForeignKey, which is not supported.Fix
Update the admin search configuration to search using the related company's name by replacing:
company→company__namein both
AddressAdminandContactAdmin.Testing