Skip to content

Resolve all ruff complaints#447

Open
mandolaerik wants to merge 28 commits into
intel:mainfrom
mandolaerik:pr/remove-broken-__all__-members
Open

Resolve all ruff complaints#447
mandolaerik wants to merge 28 commits into
intel:mainfrom
mandolaerik:pr/remove-broken-__all__-members

Conversation

@mandolaerik
Copy link
Copy Markdown
Contributor

  • remove double import
  • remove redundant f-string
  • repair function name
  • Dodge harmless name clashes
  • Remove redundant imports
  • Silence false positive for F401
  • Avoid most star imports
  • Qualify type imports using tp prefix
  • Rename TInt -> Int etc
  • Qualify ctree imports as c
  • remove unused symbol
  • Avoid star imports for DMLError
  • Avoid star imports for DMLWarning
  • Avoid star imports for PortingMessage
  • Remove messages.py
  • Remove unused imports
  • remove redundant implementation
  • remove broken __all__ members

@syssimics syssimics requested a review from lwaern-intel May 27, 2026 09:48
@syssimics
Copy link
Copy Markdown
Contributor

DML Verification : 6: ❌ failure

@syssimics
Copy link
Copy Markdown
Contributor

DML Verification : 7: ❌ failure

@syssimics
Copy link
Copy Markdown
Contributor

PR Verification: ❌ failure

@mandolaerik mandolaerik changed the title remove broken __all__ members Resolve all ruff complaints May 27, 2026
ruff complained about name clash
Silences ruff's F811, and the distinction does not hurt
Silences ruff's F401
This silences most F403 complains from ruff.

I skipped the hardest modules (`ctree`, `types` and `messages`),
those deserve a somewhat broader discussion.
The T prefix is redundant now that types are consistently qualified
with `tp.`
@mandolaerik mandolaerik force-pushed the pr/remove-broken-__all__-members branch from 7af19b0 to 2166a1c Compare May 27, 2026 10:51
@syssimics
Copy link
Copy Markdown
Contributor

DML Verification : 6: ❌ failure

@syssimics
Copy link
Copy Markdown
Contributor

DML Verification : 7: ❌ failure

@syssimics
Copy link
Copy Markdown
Contributor

PR Verification: ❌ failure

@mandolaerik mandolaerik force-pushed the pr/remove-broken-__all__-members branch from 2166a1c to a745b26 Compare May 28, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants