Skip to content

Remove some unnecessary uses of scipy#286

Merged
inducer merged 4 commits into
inducer:mainfrom
alexfikl:remove-scipy
May 29, 2026
Merged

Remove some unnecessary uses of scipy#286
inducer merged 4 commits into
inducer:mainfrom
alexfikl:remove-scipy

Conversation

@alexfikl
Copy link
Copy Markdown
Collaborator

  1. Replaced the uses of scipy.special.factorial with mi_factorial in coefficient tests. Hopefully fixes https://gitlab.tiker.net/inducer/sumpy/-/jobs/957466.
  2. Replaced uses of scipy.fftpack with numpy.fft.
  3. Replaced some uses of Legendre and Chebyshev functions in point_calculus.

Comment thread doc/misc.rst
@alexfikl alexfikl marked this pull request as draft May 29, 2026 07:48
@alexfikl alexfikl requested a review from Copilot May 29, 2026 07:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces SciPy usage by replacing selected SciPy helpers with NumPy or existing sumpy utilities in tests and point calculus code.

Changes:

  • Replaced scipy.special.factorial usage in coefficient tests with multi-index helpers.
  • Replaced scipy.fftpack.diff with NumPy FFT-based differentiation.
  • Replaced SciPy Legendre/Chebyshev helpers and corrected a documentation typo.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sumpy/test/test_m2m_coeffs.py Uses existing multi-index helpers for powers, sums, and factorials.
sumpy/test/test_l2l_coeffs.py Uses existing multi-index helpers for powers, sums, and factorials.
sumpy/test/geometries.py Replaces SciPy FFT differentiation in torus geometry generation.
sumpy/test/curve.py Adds NumPy FFT-based periodic differentiation for curve geometry.
sumpy/point_calculus.py Replaces SciPy Legendre and Chebyshev routines with NumPy-based code.
doc/misc.rst Corrects the project name in acknowledgments.
.basedpyright/baseline.json Updates static type-checking baseline entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sumpy/test/geometries.py
Comment thread sumpy/point_calculus.py
@alexfikl alexfikl marked this pull request as ready for review May 29, 2026 08:39
@inducer
Copy link
Copy Markdown
Owner

inducer commented May 29, 2026

Thanks!

@inducer inducer merged commit c65b056 into inducer:main May 29, 2026
9 checks passed
@alexfikl alexfikl deleted the remove-scipy branch May 29, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants