Add tests for `pathtools.listdir_matching` by lguerard · Pull Request #122 · imcf/python-imcflibs

lguerard · 2026-01-14T14:20:27Z

codecov · 2026-01-14T14:28:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29%. Comparing base (5f21448) to head (b70ff13).
⚠️ Report is 11 commits behind head on devel.

Additional details and impacted files

@@         Coverage Diff          @@
##           devel   #122   +/-   ##
====================================
+ Coverage     25%    29%   +4%     
====================================
  Files         25     25           
  Lines       1756   1761    +5     
====================================
+ Hits         439    514   +75     
+ Misses      1317   1247   -70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ehrenfeu · 2026-01-21T11:42:02Z

As indicated by codecov, there are still quite some paths in the function that are not covered by tests:

https://app.codecov.io/gh/imcf/python-imcflibs/pull/122/blob/src/imcflibs/pathtools.py#L223

To me, the level of complexity / conditional nesting / ... of listdir_matching is so high that sooner or later it will blow up if it's not fully covered.

ehrenfeu · 2026-03-25T13:49:21Z

Is it possible to also cover the fullpath branches in the tests?

https://app.codecov.io/gh/imcf/python-imcflibs/pull/122/blob/src/imcflibs/pathtools.py#L234

lguerard · 2026-03-25T14:45:35Z

How do I ask Codecov to check now ? I have pushed but don't see anything : https://app.codecov.io/gh/imcf/python-imcflibs/pull/122

ehrenfeu · 2026-03-25T17:22:28Z

How do I ask Codecov to check now ? I have pushed but don't see anything : https://app.codecov.io/gh/imcf/python-imcflibs/pull/122

Good question. I don't fully understand why it's not happening automatically.

Codecov seems to be complaining with Unable to compare commits because the head commit did not upload a coverage report, will need to dig into that 👷🏼

ehrenfeu · 2026-03-25T18:23:54Z

I'm not entirely certain if this is not a bug. Renewed the Codecov token now (which was still valid) and merged devel into this PR-branch as this was one of the Google suggestions on how to fix the head report issue. Let's see...

ehrenfeu · 2026-03-25T19:43:46Z

Reverted the devel merge again as this doesn't seem to make a difference...

ehrenfeu · 2026-03-25T20:25:28Z

Okay, I think by now I have identified the underlying issue with Codecov.

Codecov reports are being generated (and uploaded to Codecov) by the Pytest-Poetry 🧪🎭 action, but until 5f21448 the action was only triggered by pushes to master and for PR's, leading to the situation that for most commits in the devel branch no "direct" coverage report was available (only the "implicit" ones that were generated for their respective PR's, but apparently this confused Codecov in figuring out which is the correct report to compare a new one to).

With the commit mentioned above, the tests will also run for pushes to devel (this includes merging of PR's) and therefore the coverage reports will be updated (and uploaded to Codecov).

ehrenfeu · 2026-03-25T20:36:18Z

Suggestion: I'll try to rebase (waaaaaah! reeeebaaaase! 🤯 💥 👻 🫨 😱) the commits in this PR onto current devel and force-push here. If that works, it should trigger the tests, upload coverage and have a proper base reference for the coverage report to compare to.

I'll keep the original PR in a separate branch around, just to be safe.

🎁 Bonus: it'll give you the opportunity to fix the committer address of your last two commits as they're currently done as laurent.guerard42@gmail.com instead of laurent.guerard@unibas.ch...

* Implement tests for non-recursive and recursive matching. * Validate fullpath and regex matching functionality. * Ensure correct sorting behavior for file names.

* Implement test for invalid regex returning an empty list. * Add test for recursive regex matching that verifies absolute paths.

ehrenfeu · 2026-03-25T20:49:52Z

💥

(done ✅)

ehrenfeu · 2026-03-25T20:57:33Z

Is it possible to also cover the fullpath branches in the tests?

https://app.codecov.io/gh/imcf/python-imcflibs/pull/122/blob/src/imcflibs/pathtools.py#L234

While the commits in this PR now push the coverage by more than 50% 🚀 to a total of almost 95% 🥳 🎉 , the fullpath branches are still missing... 🤔

ehrenfeu · 2026-03-25T21:41:47Z

🚨 @lguerard please make sure to ~~git pull~~ delete your local branch and create a new one from the PR before continuing your work on this!! 🚨

…size, join_files_with_channel_suffix, and create_directory functions

…ecursive checks

This covers both recursive and non-recursive scenarios.

lguerard · 2026-03-26T11:06:57Z

Now 100% for this file 🥳

lguerard changed the base branch from master to devel January 14, 2026 14:21

ehrenfeu changed the title ~~Fix/119 listdir matching tests~~ Add tests for listdir_matching Jan 21, 2026

ehrenfeu added the unit testing A unit test should be created label Jan 21, 2026

ehrenfeu added this to imcflibs Jan 21, 2026

ehrenfeu moved this to In review in imcflibs Jan 21, 2026

ehrenfeu self-assigned this Jan 21, 2026

ehrenfeu self-requested a review January 21, 2026 11:28

ehrenfeu approved these changes Jan 21, 2026

View reviewed changes

ehrenfeu added this to the 2.0.0 milestone Jan 21, 2026

ehrenfeu assigned lguerard and unassigned ehrenfeu Mar 25, 2026

ehrenfeu changed the title ~~Add tests for listdir_matching~~ Add tests for pathtools.listdir_matching Mar 25, 2026

ehrenfeu force-pushed the fix/119-listdir-matching-tests branch from 9dae485 to fad0e28 Compare March 25, 2026 19:42

lguerard added 2 commits March 25, 2026 21:38

test(listdir): add tests for listdir_matching function

e2d6fa1

* Implement tests for non-recursive and recursive matching. * Validate fullpath and regex matching functionality. * Ensure correct sorting behavior for file names.

test(listdir): add tests for invalid regex and recursive matching

f233cf1

* Implement test for invalid regex returning an empty list. * Add test for recursive regex matching that verifies absolute paths.

ehrenfeu force-pushed the fix/119-listdir-matching-tests branch from fad0e28 to 0be95a9 Compare March 25, 2026 20:49

ehrenfeu moved this from In review to In progress in imcflibs Mar 25, 2026

fix(listdir): use absolute paths for matching files in listdir_matching

f6a4cbb

test(pathtools): add tests for find_dirs_containing_filetype, folder_…

ce25066

…size, join_files_with_channel_suffix, and create_directory functions

lguerard force-pushed the fix/119-listdir-matching-tests branch from 0be95a9 to ce25066 Compare March 26, 2026 10:44

lguerard added 2 commits March 26, 2026 11:51

test(listdir): enhance tests for listdir_matching with fullpath and r…

a9539a1

…ecursive checks

test: add tests for fullpath option in listdir_matching

b70ff13

This covers both recursive and non-recursive scenarios.

Conversation

lguerard commented Jan 14, 2026

Uh oh!

codecov bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ehrenfeu commented Jan 21, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguerard commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

ehrenfeu commented Mar 25, 2026

Uh oh!

lguerard commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 14, 2026 •

edited

Loading

ehrenfeu commented Mar 25, 2026 •

edited

Loading