ext/gettext: avoid NULL deref in textdomain/bindtextdomain#47
Closed
ext/gettext: avoid NULL deref in textdomain/bindtextdomain#47
Conversation
Both functions can return NULL on libintl-internal allocation failure. The PHP wrappers passed the result directly to RETURN_STRING, which calls strlen(NULL) and segfaults. Mirrors 0221cee, which closed the same gap for bindtextdomain($domain, NULL). textdomain()'s return type widens from string to string|false.
iliaal
force-pushed
the
gettext-null-deref-hardening-8.4
branch
from
a35fd15 to
b7039f2
Compare
Owner
Author
|
Superseded by php#21882. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
textdomain()andbindtextdomain($domain, $dir)can return NULL on libintl-internal allocation failure. RETURN_STRING then calls strlen(NULL) and crashes.0221cee closed the same gap for
bindtextdomain($domain, NULL). The other two sites get the same guard.textdomain()widens fromstringtostring|false.