IBX-11553: Made http-cache response taggers more specialized#78
Merged
Conversation
konradoboza
force-pushed
the
ibx-11553-reponse-taggers-increased-verbosity
branch
3 times, most recently
from
67c22f3 to
2df0e85
Compare
konradoboza
force-pushed
the
ibx-11553-reponse-taggers-increased-verbosity
branch
9 times, most recently
from
6512235 to
31c7b18
Compare
konradoboza
changed the title
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
mikadamczyk and
wiewiurdp
and removed request for
a team
konradoboza
force-pushed
the
ibx-11553-reponse-taggers-increased-verbosity
branch
2 times, most recently
from
659629c to
26736f7
Compare
Steveb-p
approved these changes
Apr 9, 2026
barw4
approved these changes
Apr 9, 2026
vidarl
approved these changes
Apr 9, 2026
tomaszszopinski
force-pushed
the
ibx-11553-reponse-taggers-increased-verbosity
branch
from
e9184b3 to
a4b7c75
Compare
|
tomaszszopinski
approved these changes
May 6, 2026
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on Ibexa DXP 5.0 exp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressions: ibexa/commerce#1760 ✅
Description:
This serves as a DX improvement in regards to the report from community, it's nicely summarized by @mnocon here: ibexa/documentation-developer#3109.
Generally speaking
DispatcherTaggerisn't much of a strategy - each tagger that is available here is getting the value regardless if it can work or not with no indication what happened whatsoever.Several changes within this PR aim to improve the overall situation with keeping BC promise for the custom implementations of
Ibexa\Contracts\HttpCache\ResponseTagger\ResponseTagger:AbstractValueTagger- I introducedabstract public function supports(mixed $value): bool;there not to break BC in the interface itself,supports()method beforehand,supports()method - they will be called as before (added proper deprecartion),DisptacherTagger::__toStringmethod to list available implementation tagged withibexa.cache.http.response.tagger,features/setup/symfonyCache.featurewas changed as the patch stopped being applicable - this is the result of Symfony recipes change: symfony/recipes@24e94e5For QA:
Documentation: