fix(ansible): load the shared vars for every inventory - #87
Open
catinspace-au wants to merge 1 commit into
Open
Conversation
hyperi_github_token, hyperi_github_headers, hyperi_github_env and hyperi_core_versions lived in inventories/localhost/group_vars, so playbooks/main.yml only worked with that one inventory. Against any other, a test VM or a fleet host, the first task to reference them failed undefined - the Rust role's build-environment step, on a clean VM, after thirty tasks had run. The variables belong to the playbook, not to one inventory: they are read from the control node's environment and name the versions the roles install. Moved to playbooks/group_vars, which Ansible loads beside the playbook for whatever inventory is passed. The localhost install path is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hyperi_github_token, hyperi_github_headers, hyperi_github_env and
hyperi_core_versions lived in inventories/localhost/group_vars, so
playbooks/main.yml only worked with that one inventory. Against any
other, a test VM or a fleet host, the first task to reference them
failed undefined - the Rust role's build-environment step, on a clean
VM, after thirty tasks had run. The variables belong to the playbook,
not to one inventory: they are read from the control node's
environment and name the versions the roles install. Moved to
playbooks/group_vars, which Ansible loads beside the playbook for
whatever inventory is passed. The localhost install path is unchanged.