Summary
roles/developer/tasks/removals.yml:307 removes the Remmina flatpak on the stated grounds that a native package has taken over:
# Slack and Remmina came from Flathub until 741e4b2 moved them to native
# packages, and that commit added no tombstone -- so a host provisioned before
# it runs both copies, with two entries in the app grid and two update paths.
# The native package is the one the repo now manages.
The native Remmina package is installed by roles/rdp-client/tasks/client.yml. That role is not reachable from the tags that run the removal.
The gap
roles/rdp-client does not appear in playbooks/main.yml at all. It is reached only as a meta dependency of soe-gui.
roles/soe-gui/meta/main.yml:9 states: "anyone else can take it standalone with --tags rdp-client". Because the role is absent from the play, that tag matches nothing and installs nothing.
removals.yml runs under --tags removals or --tags soe. Only the soe path also pulls soe-gui and therefore rdp-client.
Impact
A host converged with --tags removals (or removals combined with contributor) has the Remmina flatpak removed and no native package installed in its place. The user is left with no Remmina at all.
Reproduced on Ubuntu 26.04: org.remmina.Remmina present from Flathub, no remmina deb installed, and a --check run reported the flatpak removal as changed with nothing installing the replacement.
Suggested fix
Two things, either of which closes it:
- Add
rdp-client to playbooks/main.yml with tags: ['rdp-client', 'never'], which also makes the soe-gui comment true.
- Have the Remmina tombstone depend on the native package being present, so the removal cannot run ahead of its replacement.
Summary
roles/developer/tasks/removals.yml:307removes the Remmina flatpak on the stated grounds that a native package has taken over:The native Remmina package is installed by
roles/rdp-client/tasks/client.yml. That role is not reachable from the tags that run the removal.The gap
roles/rdp-clientdoes not appear inplaybooks/main.ymlat all. It is reached only as a meta dependency ofsoe-gui.roles/soe-gui/meta/main.yml:9states: "anyone else can take it standalone with--tags rdp-client". Because the role is absent from the play, that tag matches nothing and installs nothing.removals.ymlruns under--tags removalsor--tags soe. Only thesoepath also pullssoe-guiand thereforerdp-client.Impact
A host converged with
--tags removals(orremovalscombined withcontributor) has the Remmina flatpak removed and no native package installed in its place. The user is left with no Remmina at all.Reproduced on Ubuntu 26.04:
org.remmina.Remminapresent from Flathub, noremminadeb installed, and a--checkrun reported the flatpak removal aschangedwith nothing installing the replacement.Suggested fix
Two things, either of which closes it:
rdp-clienttoplaybooks/main.ymlwithtags: ['rdp-client', 'never'], which also makes thesoe-guicomment true.