Repository navigation
Intent: preserve nested lists inside list items - #133
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nested lists vanished inside intent list items while reporting success. Closes #126.
Solution
Pass assembled children into native list-item construction.
Diff
+39 / −1 across two files.
Testing & verification
Reviewed revision:
765e49f91b6f10e1f6d40d9d330a26ae0f6bcb3a· Environment: Node 24.18.0, macOS arm64.npx vitest run dev/test/intent.test.ts: 14 passed. Both nested cases failed on the prior implementation (3 blocks instead of 8).npm run typecheck: passed.npm run verify: passed (727 tests, four existing skips; build, dependency support, authoring hashes, private-reference and package checks). Full PR CI passed: https://github.com/humanmade/block-runner/actions/runs/37173800280 (Node 20/22/24, packed consumers, WordPress proof and scope gate).Not verified: target-site rendering and manual editor acceptance. The regression proves preservation through the pinned headless parse/serialize gate.
Risk / rollout
List items now retain their intended children; the shared finalization gate remains unchanged. No configuration or migration.
Detection: parsed-tree regression failures. Rollback: revert this PR.