Fix #1642: Don't flag download as interrupted when Content-Encoding is set#1699
Open
rodionsteshenko wants to merge 1 commit intohttpie:masterfrom
Open
Fix #1642: Don't flag download as interrupted when Content-Encoding is set#1699rodionsteshenko wants to merge 1 commit intohttpie:masterfrom
rodionsteshenko wants to merge 1 commit intohttpie:masterfrom
Conversation
…ding is set When Content-Encoding (e.g. gzip) is present, the requests library transparently decompresses the response body. This means the actual bytes written will be larger than Content-Length (which reflects the compressed size). Previously, httpie would compare Content-Length against the decompressed byte count and incorrectly flag the download as 'Incomplete'. Fix: When Content-Encoding is set, skip Content-Length for progress tracking since the sizes are inherently mismatched. Also resolves the longstanding FIXME from httpie#423. Added test: test_download_with_Content_Encoding_gzip_not_interrupted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When downloading a response with
Content-Encoding: gzip, httpie reports "Incomplete download" even though the download completed successfully. This happens because:Content-Lengthreflects the compressed sizerequestslibrary transparently decompresses the bodyContent-LengthFix
When
Content-Encodingis present in the response headers, skip usingContent-Lengthfor download progress/completeness tracking since the actual bytes written will be the decompressed size.This also resolves the longstanding FIXME from #423.
Test
Added
test_download_with_Content_Encoding_gzip_not_interruptedthat:downloader.interruptedis True)Full test suite passes on macOS ARM (Apple Silicon), Python 3.12.