Converge instruction implementations to operation cores and static handlers - #291
Merged
Conversation
…egister transfers
…er-model ADC/SBC; dissolve CmosAdc/CmosSbc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Completes the CPU instruction-dispatch modernization started with the per-model descriptor tables (#288) and ordered bus sequences (#289): every opcode on both CPU models now executes through small operation cores composed per addressing mode, or bespoke static handlers where composition doesn't fit. The ~70 per-instruction classes and the interface-probing composition path are deleted.
Changes
InstructionCores): one static method per operation (loads/stores, transfers, logic, compares, shifts/rotates, INC/DEC, ADC/SBC per model, TSB/TRB, flags, and all NMOS-undocumented operations), bound to addressing modes byComposeRead/ComposeStore/ComposeImplied/ComposeRmw/ComposeBranch.SharedHandlers: stack, flow, BRK, NOP), NMOS-specific (NmosHandlers: JMP (addr) page-wrap bug, JAM), and 65C02-specific (CmosHandlers: JMP variants, PHX/PHY/PLX/PLY, defined-NOP family).InstructionBindings: the single table both models compose their 256-entry descriptor tables from, with undocumented NMOS opcodes gated by the CPU's compatibility profile at binding time.InstructionListis now a projection: its metadata is generated from the NMOS model's descriptor table instead of the descriptor tables being composed from instruction objects — the two views can no longer drift.InstructionDictionary/GetInstructionand theInstructionclass hierarchy are removed (pre-1.0 clean break).Instructions/*classes, the fourIInstructionUses*interfaces,IReadModifyWriteInstruction,AddrModeCalcResult,InstructionExtraCyclesCalculator, and the legacy table composition. Net −4.0k lines.Behavior
Zero behavior change by design, verified per migration step against the previous implementation: