fix(studio): preserve authored caption groups on import - #3900
Open
AksharP5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Opening existing captions in Studio silently moved words between groups. Seven words authored as
5 + 2became4 + 3, so editing and regenerating captions used the wrong boundaries.Fixes #3899.
How
Read each outer caption group's word count instead of averaging all words and groups. Nested layout lines do not count twice. Incomplete DOM falls back to the existing five-word grouping without dropping transcript words.
Both import paths share the existing model construction, preserving segment IDs, word IDs, timing, and defaults. No UI changes or dependencies.
Verification
5 + 2,2 + 4 + 1, alternate class names, nested lines, incomplete DOM, and generated-HTML re-import.