Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Piped rule expansion can make CURKU reach the chunk-end checkpoint before all base words are processed, potentially skipping untested work after an interruption.
1 open issue
What changed in this PR
This PR addresses negative progress reporting in the Python agent for preprocessor and other piped hashcat runs, targeting server issue #2634.
Changes:
- Adds a checkpoint helper that applies the chunk offset to piped progress and clamps it to the chunk end.
- Captures piping mode before status processing and uses the helper in progress reports.
- Adds unit tests for direct runs, piped offsets, zero restore points, and clamping.
| File | Description |
|---|---|
tests/test_keyspace_progress.py |
Adds checkpoint calculation tests. |
htpclient/hashcat_cracker.py |
Adds and integrates piped checkpoint adjustment. |
Review effort: Balanced
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

fixes python agent for hashtopolis/server#2634