Skip to content

fix(#183): "b" back key does nothing in the execution log viewer - #200

Merged
sawka-harness merged 5 commits into
mainfrom
fix/view-ui-back
Sep 8, 2026
Merged

fix(#183): "b" back key does nothing in the execution log viewer#200
sawka-harness merged 5 commits into
mainfrom
fix/view-ui-back

Conversation

@BlueLabelscotch

@BlueLabelscotch BlueLabelscotch commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Pressing b in the --ui execution log viewer (v from an execution row) did nothing — it's a standalone tea.Program that never got wired into the app-wide b-for-back convention.

  • logviewer.go: b now cancels streams and quits, same as q.
  • cmdctx.go: added UIWantBack (default false) so a view-handler can opt into "go back" instead of "quit".
  • uitableview.go: finishUIExit now only pops/redraws history when UIWantBack is set.
  • Help footer now shows b back.

fix for #183

@BlueLabelscotch

Copy link
Copy Markdown
Collaborator Author

@sawka-harness , ctx.Resolver.RunUIHandler(ctx, uc.UIHandlerFn) calls handler functions and never gets a logViewModel back, so we can't structurally know if the viewer decided to go 'b' back or 'q' quit , needed to add a common flag in the ctx, which will be changed inside the log viewer to carry that info to the finishUiexit, that will solve our log view problem.

@sawka-harness
sawka-harness merged commit 9479ae4 into main Sep 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants