✨ feat(mq-lang,mq-run): add --allow-all flag to grant every sandbox permission - #2093
Merged
Conversation
…ermission Add SandboxedIo::allow_all(), a preset that grants read/write/net/run/env all at once, and wire it to mq-run's --allow-all flag. Deno's -A/--allow-all shorthand isn't available here (-A is already --aggregate), and none of the existing --allow-read/write/net/run/env flags have short forms either, so --allow-all is long-only on purpose given it bypasses all sandboxing.
… flags, add -a short form conflicts_with_all rejects --allow-all alongside --allow-net/read/write/run/env at parse time with a clear clap error, instead of silently overriding their values. Also add -a as a short form: unlike the other --allow-* flags (which stay long-only), --allow-all mirrors Deno's -A/--allow-all convention — -A itself is unavailable here since it's already --aggregate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add SandboxedIo::allow_all(), a preset that grants read/write/net/run/env
all at once, and wire it to mq-run's --allow-all flag. Deno's -A/--allow-all
shorthand isn't available here (-A is already --aggregate), and none of
the existing --allow-read/write/net/run/env flags have short forms either,
so --allow-all is long-only on purpose given it bypasses all sandboxing.
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context