Repository navigation
fix(docker): use repo root as build context so shared/ is available to both tiers - #2219
Merged
Merged
Conversation
This was referenced Oct 6, 2026
trillium
approved these changes
Oct 6, 2026
trillium
left a comment
Member
There was a problem hiding this comment.
Good change, lets us use @ imports properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2229
Related: #2230 (the AWS deploy workflows still build from the per-tier context and need the same fix).
What changes did you make and why did you make them ?
shared/lives at the repo root and is imported by both the client and the backend, but the Docker builds used./clientand./backendas their build contexts — soshared/was never copied into either image and the builds failed on the missing imports.docker-compose.yml,.github/workflows/all-merges.yaml) and updated everyCOPYpath inbackend/Dockerfile.api,client/Dockerfile.client, andclient/Dockerfile.prodto be root-relative.shared/is now copied to/srv/sharedin both images../shared:/srv/sharedas a volume on theclientservice so dev-mode hot reload picks up changes to shared code (the backend service already mounted the repo differently).@sharedalias inclient/vite.config.mjspointing at<repoRoot>/shared, plusserver.fs.allow: [repoRoot]so the Vite dev server is permitted to serve files outside its root.shared/imports inNavbar.jsx,selectProject.jsx,EditUsers.jsx,authContext.jsx, andProjectList.jsxwith@shared/.... These previously varied by nesting depth (../../../sharedvs../../../../shared), which is what made them fragile in the first place.FROM nginx as→FROM nginx ASinDockerfile.clientto clear the Docker build warning, and Prettier formatting on the touched client files.How to test
Both images should build, and the client should resolve
@shared/roles/@shared/authorizationUtilsin dev and in the production (nginx) target.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No user-facing visual changes — build configuration and import paths only.
🤖 Generated with Claude Code