Add project type filter to ysws review page#148
Open
bbarni2020 wants to merge 1 commit intohackclub:stagingfrom
Open
Add project type filter to ysws review page#148bbarni2020 wants to merge 1 commit intohackclub:stagingfrom
bbarni2020 wants to merge 1 commit intohackclub:stagingfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “project type” dimension to the YSWS admin review page so reviewers can see (and filter by) the underlying editor/file source (Onshape/Fusion/etc.).
Changes:
- Add a multi-select “Type” filter to the YSWS review filter form.
- Extend the server query payload to include editor/file fields and apply a type filter via
getProjectLinkType(). - Display the derived project type on each project card.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/routes/dashboard/admin/ysws-review/+page.svelte |
Adds the Type filter UI and shows the derived type per project. |
src/routes/dashboard/admin/ysws-review/+page.server.ts |
Adds type handling to the form action and filters project results by derived link type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+116
to
+123
| <option value="onshape" class="truncate">Onshape</option> | ||
| <option value="fusion-link" class="truncate">Fusion Link</option> | ||
| <option value="fusion-file" class="truncate">Fusion File</option> | ||
| <option value="blender" class="truncate">Blender</option> | ||
| <option value="freecad" class="truncate">FreeCAD</option> | ||
| <option value="solvespace" class="truncate">SolveSpace</option> | ||
| <option value="unknown" class="truncate">Other</option> | ||
| </select> |
There was a problem hiding this comment.
The project type <option> list is hardcoded here (and appears duplicated in the non-YSWS admin review page). To reduce the risk of UI options drifting from getProjectLinkType() return values, consider exporting a single shared mapping/list (e.g., projectLinkTypeLabels) from $lib/utils and rendering options from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.