Attempt to avoid errors on aliased 'contains'#52
Open
cursork wants to merge 1 commit intoguns:masterfrom
Open
Conversation
Owner
|
Thanks Neil, this sounds awfully familiar; I must have broken your fix to this very same problem when refactoring for the new syntax_keyword variables. Using |
Author
|
Ha sorry - it seemed familiar to me too but I managed to convince myself I was imagining it! For some unknown reason 😧 Thanks for taking a look. For reference: guns/vim-clojure-highlight#1 |
|
👍 |
1 similar comment
|
👍 |
|
Any chance of getting this merged? Biting me a little now too. |
|
Any reason this hasn't been merged yet? |
Owner
|
I believe there was, but I'll have another look. |
|
Is there any temporary fix that we could do to avoid this issue? I am experiencing the same issue |
lucasalencar
added a commit
to lucasalencar/dotfiles
that referenced
this pull request
Jan 21, 2019
Avoid issue described by this PR guns/vim-clojure-static#52 Add forked repository with the fix proposed in the PR. Move vim-polyglot to the end of Plugs to prioritize highlighting that are declared before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users with vim-clojure-static and vim-clojure-highlight see errors and broken highlighting when opening some test files. The culprit is
[midje.sweet :refer :all]as that includes a functioncontains. And this is illegal in Vim:Similarly a couple of other words (oneline, concealends) will not be recognised; but I'd be very surprised if they turned up in much code!
Note that my example code attached still doesn't highlight 'contains' correctly - for the life of me I can't figure out why as the regular expression generated appears under clojureFunc when I call
:syntaxand pasting that regexp into a manual:syntax matchis fine.