Revert "Move self-hosted video dimensions to Source object"#15577
Merged
Revert "Move self-hosted video dimensions to Source object"#15577
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
added
the
maintenance
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @abeddow91 7 minutes and 56 seconds ago) Please check your changes! |
abeddow91
added a commit
that referenced
this pull request
Mar 24, 2026
…15578) * Revert "Revert "Move self-hosted video dimensions to Source object" (#15577)" This reverts commit 4dd0044. * Add the aspect ratio to the source model and allow the sources to be sorted by mime type and then by width * Make height and width required in enhance cards with a 0 fallback * Prefer first source over first asset so that we always pick the head source that has been sorted and will be preferred by the player when setting the aspect ratio * Generate schemas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #15556.
This is breaking the aspect ratio of in article videos by making any aspect ratio (except for 5:3) appear letter boxed in a 5:3 container. This is the behaviour for front cards but should not be the experience in article.