Show fallback when error fetching match header data#15567
Open
jamesmockett wants to merge 3 commits intomainfrom
Open
Show fallback when error fetching match header data#15567jamesmockett wants to merge 3 commits intomainfrom
jamesmockett wants to merge 3 commits intomainfrom
Conversation
jamesmockett
force-pushed
the
jm/match-header-fallback
branch
from
de2d674 to
c58f04e
Compare
jamesmockett
changed the title
jamesmockett
force-pushed
the
jm/match-header-fallback
branch
from
c58f04e to
df5e360
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a fallback header displaying the article title and headline if we are unable to render the match header due to an error fetching match data. This also hides the mini match stats placeholder if an error occurs when fetching data.
Why?
We don't have data available for all matches so this prevents live blogs from appearing broken if we're unable to load the match header.
Screenshots