Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
force-pushed
the
ab-eh/bridget-is-autoplay-enabled
branch
2 times, most recently
from
bdbb791 to
590bcfb
Compare
abeddow91
commented
Mar 11, 2026
RikRootsGuardian
approved these changes
Mar 11, 2026
Contributor
RikRootsGuardian
left a comment
RikRootsGuardian
left a comment
There was a problem hiding this comment.
This PR is adding new functionality for prefers-reduced-motion user preference in apps. The existing checks for web remain intact. Happy to approve.
abeddow91
force-pushed
the
ab-eh/bridget-is-autoplay-enabled
branch
from
8ee265b to
7d466c1
Compare
…able on the video client. If the client is using a version lower than 8.8.0, autoplay is set to true to preserve existing behaviour
abeddow91
force-pushed
the
ab-eh/bridget-is-autoplay-enabled
branch
from
8bf22a1 to
5fdaaa3
Compare
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @abeddow91 10 minutes and 29 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a call to check the autoplay status of the native apps. To access the isAutoplayEnabled method, the client must be on version 8.8.0 or higher. If not, DCR will continue with existing behaviour and return true for autoplay.
Why?
So that self hosted videos in articles respect in-app accessibility settings.