Add Vue support to 5 existing rules and enhance documentation#115
Open
neptia wants to merge 4 commits into
Open
Add Vue support to 5 existing rules and enhance documentation#115neptia wants to merge 4 commits into
neptia wants to merge 4 commits into
Conversation
MP-Aubay
requested changes
May 20, 2026
MP-Aubay
left a comment
MP-Aubay
left a comment
Contributor
There was a problem hiding this comment.
You should also update CHANGELOG.md
Member
|
Hello @neptia 👋 Thank you for the contribution! |
MP-Aubay
reviewed
Jun 2, 2026
| ### Changed | ||
|
|
||
| - [#107](https://github.com/green-code-initiative/creedengo-javascript/pull/107) Move to creedengo-rules-specifications v3 | ||
| - Add Vue SFC template support to JSX‑based rules (avoid-autoplay, no-empty-image-src-attribute, prefer-lighter-formats-for-image-files, avoid-css-animations, prefer-shorthand-css-notations) |
Contributor
There was a problem hiding this comment.
Could you just add the PR URL before the description ?
Contributor
…template examples and compliance notes
MP-Aubay
approved these changes
Jun 16, 2026
Contributor
|
@utarwyn it's all good to me, do you want to check it before merge ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODIFICATION OF EXISTING RULES
Added Vue SFC support for JSX‑based rules using Vue template AST visitors (vue-eslint-parser).
Updated RuleTester unit tests with Vue template cases for modified rules.
Added Vue integration examples in the test project and verified lint warnings on .vue files.
Covered rules: avoid-autoplay, no-empty-image-src-attribute, prefer-lighter-formats-for-image-files, avoid-css-animations, prefer-shorthand-css-notations.