Open
Conversation
|
|
|
|
makhnatkin
force-pushed
the
fix/circular-deps-gpt
branch
from
c90e94c to
7507d11
Compare
makhnatkin
changed the title
makhnatkin
force-pushed
the
fix/circular-deps-bundle
branch
from
926823a to
ffb6e62
Compare
makhnatkin
force-pushed
the
fix/circular-deps-gpt
branch
from
7507d11 to
fee5850
Compare
makhnatkin
force-pushed
the
fix/circular-deps-bundle
branch
from
ffb6e62 to
3fcbbb7
Compare
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
makhnatkin
force-pushed
the
fix/circular-deps-gpt
branch
from
fee5850 to
f980d0d
Compare
makhnatkin
force-pushed
the
fix/circular-deps-bundle
branch
from
3fcbbb7 to
3bf05da
Compare
d3m1d0v
reviewed
Apr 17, 2026
|
|
||
| import './MarkdownEditorView.scss'; | ||
| import '../styles/styles.scss'; | ||
| import './MarkdownEditorView.scss'; // eslint-disable-line import/order |
Member
There was a problem hiding this comment.
It is very likely that this is an important order of importing styles and should not be changed unless necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category C —
bundle/MarkdownEditorView.tsxdeclared and exportedcnEditorComponent.bundle/HorizontalDrag.tsximportedcnEditorComponentfromMarkdownEditorView; butMarkdownEditorViewimported theHorizontalDragcomponent — closing the cycle.Fix: extract
cnEditorComponenttobundle/editor-classname.ts(which imports nothing fromwithin
bundle/). BothMarkdownEditorView.tsxandHorizontalDrag.tsximport fromeditor-classname.ts.After this PR: 0 circular dependencies. Threshold set to 0.