Merged
Conversation
|
|
|
|
makhnatkin
force-pushed
the
fix/circular-deps-utils
branch
from
2bdc946 to
3ccab58
Compare
makhnatkin
force-pushed
the
fix/circular-deps-markup
branch
from
b88eb17 to
278df10
Compare
makhnatkin
changed the title
makhnatkin
force-pushed
the
fix/circular-deps-utils
branch
from
3ccab58 to
d1c5ecb
Compare
makhnatkin
force-pushed
the
fix/circular-deps-markup
branch
from
278df10 to
a3fc563
Compare
makhnatkin
commented
Apr 16, 2026
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
makhnatkin
force-pushed
the
fix/circular-deps-utils
branch
from
d1c5ecb to
895da92
Compare
makhnatkin
force-pushed
the
fix/circular-deps-markup
branch
from
51bc15c to
60e2f22
Compare
d3m1d0v
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cycle categories:
Category D —
files-upload-facet.tspassedFilesUploadPlugin.extensiontoFacet.define({enables}).CodeMirror evaluates
enablesat module load time, not call time.FilesUploadPluginimportedFileUploadHandlerFacet— both files deadlocked at startup.Fix: remove
enables, registerFilesUploadPlugin.extensionexplicitly increate.ts.Category A —
commands/inline.tsimportedDirectiveSyntaxFacetthrough the../codemirrorbarrel.Fix: import directly from
../codemirror/directive-facet.