Skip to content

ci: skip the coverage comment on pull requests from forks - #1034

Merged
dkhawk merged 3 commits into
mainfrom
ci/skip-coverage-comment-on-forks
Oct 9, 2026
Merged

dkhawk merged 3 commits into
mainfrom
ci/skip-coverage-comment-on-forks

Conversation

@kikoso

@kikoso kikoso commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

The "Jacoco Report to PR" step in the instrumentation workflow posts the coverage comment with secrets.SYNCED_GITHUB_TOKEN_REPO. Pull requests from forks do not get repository secrets, so the token is empty and the step fails with 'token' is missing, which marks run-instrumentation-test as failed even when every test passed. That happened on #1029.

This skips the step for fork pull requests only. The emulator tests still run and the reports are still uploaded as artifacts; same-repo PRs, workflow_dispatch and repository_dispatch runs keep posting the comment as before.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Coverage (unit tests)

Compared against cb74115 on main (#1031).

Module Line % Change Branch % Change
maps-compose 0.00% no change 0.00% no change
maps-compose-utils 2.04% no change 0.49% no change
maps-compose-widgets 0.00% no change 0.00% no change
TOTAL 0.41% no change 0.09% no change

Line and branch coverage from unit test reports. History is recorded on the coverage-history branch after each merge to main.

@googlemaps-bot

Copy link
Copy Markdown
Contributor

Coverage (instrumentation tests)

Overall Project 44.45% 🍏

There is no coverage information present for the Files changed

@googlemaps-bot

Copy link
Copy Markdown
Contributor

Code Coverage

Overall Project 44.43% 🍏

There is no coverage information present for the Files changed

@kikoso
kikoso marked this pull request as ready for review October 9, 2026 08:02
@kikoso
kikoso requested a review from a team as a code owner October 9, 2026 08:02
@dkhawk
dkhawk merged commit 85a56aa into main Oct 9, 2026
13 checks passed
@dkhawk
dkhawk deleted the ci/skip-coverage-comment-on-forks branch October 9, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants