fix: do not retry HTTP 501 for Interactions API requests - #2809
Open
a2105z wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
a2105z
force-pushed
the
fix/interactions-delete-no-retry-501
branch
2 times, most recently
from
August 4, 2026 01:04
3754b9b to
5bc6a5d
Compare
Align NextGen retry status codes with the parent client so permanent failures like 501 Not Implemented are not retried as transient 5XX errors. Relates to interactions.delete returning 501 (googleapis#2803).
a2105z
force-pushed
the
fix/interactions-delete-no-retry-501
branch
from
August 4, 2026 01:05
5bc6a5d to
81d36e9
Compare
Author
|
@googlebot I fixed it. |
Author
|
@Venkaiahbabuneelam this PR stops Interactions requests from retrying permanent HTTP 501s (aligned with the parent client); whenever you have a moment, I would really appreciate your review — thank you for your time. |
Author
|
Sorry — I accidentally closed this PR. Reopened. @Venkaiahbabuneelam whenever you have a moment, I'd really appreciate a review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
408,429,500,502,503,504) instead of Speakeasy's broad5XXclass.interactions.deletein Interactions API: interactions.delete returns 501 with Gemini Developer API #2803).interactions.deletefails fast on 501.Notes
The documented
DELETE /v1beta/interactions/{id}path constructed by the SDK looks correct. The 501 itself appears to be a Gemini Developer API backend response (similar to #1971 forcancel). This PR does not claim to make delete succeed server-side; it fixes the SDK treating 501 as a transient error and retrying untilInternalServerError.Fixes client-side retry behavior for #2803.
Test plan
pytest google/genai/tests/interactions/test_auth.py::test_interactions_delete_does_not_retry_501pytest google/genai/tests/interactions/test_auth.py::test_async_interactions_delete_does_not_retry_501test_interactions_gemini_retry/ async variant still pass (500 still retried; 501 fails fast)